[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/24] hw/[u-x]*: pass owner to memory_region_in
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 24/24] hw/[u-x]*: pass owner to memory_region_init_io |
|
Date: |
Tue, 02 Jul 2013 07:49:51 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 02/07/2013 01:42, Andreas Färber ha scritto:
> I happened to notice that the scripted approach you describe in the
> cover letter causes some unnecessary indirection here:
> In this hunk a human could've just supplied the function argument obj.
> But since OBJECT() is not a dynamic cast and f is referenced on the same
> line for the MemoryRegion itself, I guess there is no harm in always
> using OBJECT(f) for simplicity.
The conversion actually wasn't scripted, only the review. I used
OBJECT(f) because it was easier to think about, and any mistakes
(opaques that are not QOM objects) would be caught during the scripted
review.
Paolo