[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host |
|
Date: |
Tue, 02 Jul 2013 09:09:17 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-07-01 22:48, Paolo Bonzini wrote:
> Il 01/07/2013 20:33, Jan Kiszka ha scritto:
>>> This function is not used outside the iothread mutex, so it
>>> can use ram_list.mru_block.
>>
>> Add a comment to qemu_ram_addr_from_host to document this requirement?
>
> Right now there is hardly any documentation of what does _not_ require
> the iothread mutex... basically everything except qemu_safe_ram_ptr and
> qemu_ram_ptr_length requires it.
I don't disagree regarding the current state. But that doesn't imply it
has to be preserved.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux