Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls

[Paolo Bonzini]

Il 02/07/2013 11:31, Jan Kiszka ha scritto:
> On 2013-07-02 11:28, Paolo Bonzini wrote:
>> Il 02/07/2013 10:36, Jan Kiszka ha scritto:
>>>>>>> Hmm, two solutions for one problem - can we improve this in the next 
>>>>>>> round?
>>>>>
>>>>> Sure, I can adapt the hw/acpi/piix4.c to use ifs in the same style as
>>>>> hw/isa/lpc_ich9.c (I find the code easier to read).
>>> I was more referring to memory_region_present vs. open-coding.
>>
>> Understood, but once you replace ?: with "if", the memory_region_present
>> wrapper loses most of the appeal.  So I actually prefer the open-coded one.
> 
> Well, count the memory_region_unref calls.

Fair enough... I'll move memory_region_present to memory.h/c.

Paolo