qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Citrix PV Bus device


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device
Date: Tue, 02 Jul 2013 13:01:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

Il 02/07/2013 12:57, Paul Durrant ha scritto:
>>> So the reason to place the device here is TARGET_PAGE_SIZE...
>>> We really need a way to access that value from common code,
>>> somewhere down my TODO list. :/
>> 
>> Why does it need to be in pages rather than bytes?
> 
> It doesn't necessarily need to be in pages; it's just a more
> convenient quantity than bytes. Since it needs to be a power of 2 I
> could perhaps use an 'order' parameter instead?

I would just use bytes, the power-of-2 requirement can be checked in the
init function (actually it would just be caught by pci_register_bar).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]