[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand |
|
Date: |
Thu, 04 Jul 2013 10:16:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 04/07/2013 07:34, Fam Zheng ha scritto:
>> > + if ((e->flags & (BDRV_BLOCK_DATA|BDRV_BLOCK_ZERO)) ==
>> > BDRV_BLOCK_DATA) {
>> > + printf("%lld %lld %d %lld\n",
>> > + (long long) e->start, (long long) e->length,
>> > + e->depth, (long long) e->offset);
>> > + }
> Why %lld and explicit cast, not using PRId64?
Will fix.
> Is BDRV_BLOCK_DATA and BDRV_BLOCK_ZERO distinguishable here for the
> user? By offset?
I'm not sure I understand the question.
Zero blocks are always omitted in the "human" format. Only non-zero
blocks are listed.
Paolo
- Re: [Qemu-devel] [PATCH 06/17] block: expect errors from bdrv_co_is_allocated, (continued)
[Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand, Paolo Bonzini, 2013/07/03
Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand, Stefan Hajnoczi, 2013/07/15
Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand, Eric Blake, 2013/07/18
[Qemu-devel] [PATCH 11/17] block: return get_block_status data and flags for formats, Paolo Bonzini, 2013/07/03
[Qemu-devel] [PATCH 14/17] raw-posix: return get_block_status data and flags, Paolo Bonzini, 2013/07/03