[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tabl
|
From: |
Benjamin Herrenschmidt |
|
Subject: |
Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables |
|
Date: |
Tue, 09 Jul 2013 07:45:54 +1000 |
On Mon, 2013-07-08 at 13:39 -0500, Anthony Liguori wrote:
> > + .fields = (VMStateField []) {
> > + /* Sanity check */
> > + VMSTATE_UINT32_EQUAL(liobn, sPAPRTCETable),
> > + VMSTATE_UINT32_EQUAL(window_size, sPAPRTCETable),
> > +
> > + /* IOMMU state */
> > + VMSTATE_BOOL(bypass, sPAPRTCETable),
> > + VMSTATE_VBUFFER_DIVIDE(table, sPAPRTCETable, 0, NULL, 0,
> > window_size,
> > + SPAPR_TCE_PAGE_SIZE /
> > sizeof(sPAPRTCE)),
>
> Not endian safe. I really don't get the divide bit at all either.
What do you mean by not endian safe ? The TCE table is a well defined format,
it's always big endian regardless of the endianness of either host or guest.
Cheers,
Ben.