qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] gdbstub broken in master


From: Max Filippov
Subject: [Qemu-devel] gdbstub broken in master
Date: Tue, 9 Jul 2013 03:37:49 +0400

Hi Andreas,

commit c52a6b67c1d7c6fc9fb2e3ba988d7b978e1487d3
Author: Andreas Färber <address@hidden>
Date:   Fri May 17 17:49:10 2013 +0200

    gdbstub: Simplify find_cpu()

    Use qemu_get_cpu() and CPUState::env_ptr.

    Reviewed-by: Richard Henderson <address@hidden>
    Signed-off-by: Andreas Färber <address@hidden>

breaks single-stepping in gdb. This commit replaces

        if (cpu_index(cpu) == thread_id) {

with qemu_get_cpu(thread_id) call, which does the following:

        if (cpu->cpu_index == index) {

while cpu_index(cpu) used to return cpu->cpu_index + 1;

-- 
Thanks.
-- Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]