[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] qapi-schema: Use existing type for drive-backup arguments |
Date: |
Tue, 9 Jul 2013 20:45:23 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, 07/09 06:07, Eric Blake wrote:
> On 07/09/2013 05:58 AM, Fam Zheng wrote:
> > On Tue, 07/09 10:05, Kevin Wolf wrote:
> >> This removes duplicated definitions and documentation by reusing the
> >> existing data type.
> >>
> >> Signed-off-by: Kevin Wolf <address@hidden>
> >> ---
>
> >> +++ b/qapi-schema.json
> >> @@ -1791,42 +1791,14 @@
> >> # The operation can be stopped before it has completed using the
> >> # block-job-cancel command.
> >> #
> > Are these lines, ...
>
> >> -# actions will be used.
> >> +# For the arguments, see the documentation of DriveBackup.
> >> #
> >> # Returns: nothing on success
> >> # If @device is not a valid block device, DeviceNotFound
> >> #
> >> # Since 1.6
> >> ##
> > and these still duplication of those comments for type declaration?
>
> Are you talking about the lines that were elided or the lines that
> remain? The lines that were elided are duplicates of the documentation
I thought there was a duplication for the remaining. Kevin explained
that too. Thanks.
> of the DriveBackup struct; the lines that remain (command overview,
> Returns, and Since designations) must remain because they independently
> document the 'drive-backup' command. The trivial amount of remaining
> duplication (basically, the Since 1.6 line) matches what was already
> done for the blockdev-snapshot-sync command, because every entity (both
> types and commands) should mention when they were introduced. I see no
> problem with the patch.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Fam