[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 09/11] iscsi: factor out sector conversions
|
From: |
Peter Lieven |
|
Subject: |
Re: [Qemu-devel] [PATCHv2 09/11] iscsi: factor out sector conversions |
|
Date: |
Wed, 10 Jul 2013 16:07:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 |
Am 10.07.2013 13:29, schrieb Kevin Wolf:
> Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben:
>> Signed-off-by: Peter Lieven <address@hidden>
>> ---
>> block/iscsi.c | 18 +++++++++++-------
>> 1 file changed, 11 insertions(+), 7 deletions(-)
> A bit confusing that you add only one function (because the other one is
> already there), but convert both directions. Looks correct, though.
this is because qemu_sector2lun was only used for the lba, but never
for nb_sectors by Ronnie.
Peer
>
> Reviewed-by: Kevin Wolf <address@hidden>