[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming fe
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature |
Date: |
Thu, 11 Jul 2013 12:52:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/11/2013 08:28 AM, Amos Kong wrote:
> Markus added some comments on old patchset, this patch contains
> some additional fixes, it's based on MST's PCI tree.
>
> * Fix typos (missed 1.6, NIC)
> * Don't initialize list point at its declaration
> * Always notify QMP client if mactable is changed
> * Returns NULL list if no net client supports rx-filter querying.
>
> BTW, we can also use e1000 with macvtap device, so we can implement
> a query_rx_filter function for e1000 in future.
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> hw/net/virtio-net.c | 24 ++++++++++++++----------
> net/net.c | 19 ++++++++++---------
> qapi-schema.json | 11 ++++++-----
> qmp-commands.hx | 10 +++++-----
> 4 files changed, 35 insertions(+), 29 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
> @@ -3724,13 +3724,14 @@
> #
> # @all: receive all assigned packets
> #
> +# Since: 1.6
> ##
> { 'enum': 'RxState', 'data': [ 'normal', 'none', 'all' ] }
I don't see RxState in the latest qemu.git (c170a23c); is it worth
trying to squash this in place to the pull request of the earlier
series, instead of as a followup patch?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature