Re: [Qemu-devel] [PATCH v5 10/14] pc: Add dimm paravirt SRAT info

[Michael S. Tsirkin]

On Fri, Jul 12, 2013 at 09:33:28AM +0800, Hu Tao wrote:
> On Thu, Jul 11, 2013 at 11:49:01AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jul 11, 2013 at 07:13:39AM +0200, Igor Mammedov wrote:
> > > On Wed, 10 Jul 2013 13:10:03 +0300
> > > "Michael S. Tsirkin" <address@hidden> wrote:
> > > 
> > > > On Wed, Jun 26, 2013 at 05:13:33PM +0800, Hu Tao wrote:
> > > > > The numa_fw_cfg paravirt interface is extended to include SRAT 
> > > > > information for
> > > > > all hotplug-able dimms. There are 3 words for each hotplug-able 
> > > > > memory slot,
> > > > > denoting start address, size and node proximity. The new info is 
> > > > > appended after
> > > > > existing numa info, so that the fw_cfg layout does not break.  This 
> > > > > information
> > > > > is used by Seabios to build hotplug memory device objects at runtime.
> > > > > nb_numa_nodes is set to 1 by default (not 0), so that we always pass 
> > > > > srat info
> > > > > to SeaBIOS.
> > > > > 
> > > > > v3->v4: numa_fw_cfg needs to be initalized after memory controller 
> > > > > sets up dimm
> > > > > ranges.  Make changes for pc_piix and pc_q35 to set numa_fw_cfg after 
> > > > > i440fx
> > > > > initialization.
> > > > > 
> > > > > v2->v3: setting nb_numa_nodes to 1 is not needed
> > > > > 
> > > > > v1->v2:
> > > > > Dimm SRAT info (#dimms) is appended at end of existing numa fw_cfg in 
> > > > > order not
> > > > > to break existing layout
> > > > > Documentation of the new fwcfg layout is included in 
> > > > > docs/specs/fwcfg.txt
> > > > > 
> > > > > Signed-off-by: Vasilis Liaskovitis <address@hidden>
> > > > > Signed-off-by: Hu Tao <address@hidden>
> > > > 
> > > > Please do not add any more fwcfg interfaces - generating
> > > > ACPI in qemu removes the need for it.
> > > > 
> > > > So please rebase on top of that work and generate the appropriate ACPI
> > > > tables directly.
> > > > 
> > > > You can find the latest code gnerating ACPI from qemu here:
> > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi
> > > 
> > > will it work with upstream Seabios or custom tree is required for it as 
> > > well?
> > 
> > Yes.
> > 
> > git://git.kernel.org/pub/scm/virt/kvm/mst/seabios.git acpi
> 
> This means I must rebase both qemu and seabios patches on top of your
> acpi tree. I hope there won't be too much conflicts:)

Shouldn't be hard, if there's a problem pls tell me and I'll try to
help.