[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/2] object: Object apply the refcnt interface by Qr
From: |
Liu Ping Fan |
Subject: |
[Qemu-devel] [PATCH 2/2] object: Object apply the refcnt interface by Qref |
Date: |
Mon, 15 Jul 2013 10:49:16 +0800 |
Signed-off-by: Liu Ping Fan <address@hidden>
---
include/qom/object.h | 2 +-
qom/object.c | 15 +++++----------
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index 2e165fb..8426dd1 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -389,7 +389,7 @@ struct Object
ObjectClass *class;
ObjectFree *free;
QTAILQ_HEAD(, ObjectProperty) properties;
- uint32_t ref;
+ Qref ref;
Object *parent;
};
diff --git a/qom/object.c b/qom/object.c
index b2479d1..736d4ba 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -388,15 +388,15 @@ static void object_deinit(Object *obj, TypeImpl *type)
}
}
-static void object_finalize(void *data)
+static void object_finalize(Qref *qref)
{
- Object *obj = data;
+ Object *obj = container_of(qref, Object, ref);
TypeImpl *ti = obj->class->type;
object_deinit(obj, ti);
object_property_del_all(obj);
- g_assert(obj->ref == 0);
+ g_assert(qref->count == 0);
if (obj->free) {
obj->free(obj);
}
@@ -683,17 +683,12 @@ GSList *object_class_get_list(const char *implements_type,
void object_ref(Object *obj)
{
- atomic_inc(&obj->ref);
+ qref_get(&obj->ref);
}
void object_unref(Object *obj)
{
- g_assert(obj->ref > 0);
-
- /* parent always holds a reference to its children */
- if (atomic_fetch_dec(&obj->ref) == 1) {
- object_finalize(obj);
- }
+ qref_put(&obj->ref, object_finalize);
}
void object_property_add(Object *obj, const char *name, const char *type,
--
1.8.1.4