Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

[Alexey Kardashevskiy]

On 07/16/2013 07:01 PM, Alexander Graf wrote:
> 
> 
> Am 16.07.2013 um 10:45 schrieb Benjamin Herrenschmidt
> <address@hidden>:
> 
>> On Tue, 2013-07-16 at 10:32 +0200, Alexander Graf wrote:
>>>>> Did I miss anything here?
>>>> 
>>>> No, I don't think so.  The patch looks good.
>>> 
>>> ... and will break all Mac targets again, no? Not to speak of
>>> non-ppc devices.
>> 
>> Do you know why it breaks ? Can you suggest what's wrong and how to
>> fix it maybe ?
> 
> Sure. Get rid of cpu_inX and cpu_outX completely and verify that the
> conversion is doing the "right thing" for each conversion. Some of them
> are really tricky - like MIPS which accesses the RTC in native endian
> (big) in current code. So this patch would definitely break that one
> too.
> 

> I'm actually surprised we have to mark the ioport region little endian
> for sPAPR.


It is not for spapr, it is for devices which expect some endianness and do
not do convertions.


> We already did have it converted to a direct memory api alias
> a while ago and IIRC the only problem back then were the old_portio
> callbacks. I wonder what changed in between.


? We have had the IO memory region hack I am trying to remove for a long time.


-- 
Alexey