[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses base
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts |
|
Date: |
Tue, 16 Jul 2013 14:44:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-07-16 14:38, Peter Maydell wrote:
> On 16 July 2013 13:33, Paolo Bonzini <address@hidden> wrote:
>> Il 16/07/2013 14:28, Jan Kiszka ha scritto:
>>> This changed the value read from unassigned memory from -1 to 0. Any
>>> particular reason or an unintentional change?
>>
>> Cut-and-paste (unassigned RAM used to return 0, invalid MMIO used to
>> return -1, unifying the paths dropped the difference).
>>
>> I guess unassigned RAM can read as -1 just fine, so we can just change
>> unassigned_mem_read to return -1.
>
> Behaviour for accesses to unassigned addresses should really
> be both bus and CPU specific...
Yes, that's what I was thinking as well when reading it. Still, lets
restore what we did before, then refine.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux