Re: [Qemu-devel] [RFC 2/6] OptsVisitor: introduce list modes for interval flattening

[Paolo Bonzini]

Il 18/07/2013 15:59, Laszlo Ersek ha scritto:
> The new modes are equal-rank, exclusive sub-modes of LM_IN_PROGRESS. Teach
> opts_next_list(), opts_type_int() and opts_type_uint64() to handle them.

Perhaps you could use a bitmap then:

     LM_NONE = 0
     LM_STARTED = 1
     LM_IN_PROGRESS = 2
     LM_SIGNED_INTERVAL = LM_IN_PROGRESS | 4
     LM_UNSIGNED_INTERVAL = LM_IN_PROGRESS | 8

I think the only change would be that this hunk:

> @@ -211,7 +238,10 @@ opts_end_list(Visitor *v, Error **errp)
>  {
>      OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
>  
> -    assert(ov->list_mode == LM_STARTED || ov->list_mode == LM_IN_PROGRESS);
> +    assert(ov->list_mode == LM_STARTED ||
> +           ov->list_mode == LM_IN_PROGRESS ||
> +           ov->list_mode == LM_SIGNED_INTERVAL ||
> +           ov->list_mode == LM_UNSIGNED_INTERVAL);
>      ov->repeated_opts = NULL;
>      ov->list_mode = LM_NONE;
>  }

could be changed to

        assert(ov->list_mode == LM_STARTED ||
               (ov->list_mode & LM_IN_PROGRESS));

Paolo