qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V7 04/13] monitor: avoid use of global *cur_mon


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V7 04/13] monitor: avoid use of global *cur_mon in monitor_find_completion()
Date: Sat, 20 Jul 2013 06:02:05 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> Parameter *mon is added, and local variable *mon added in previous patch
> is removed. The caller readline_completion(), pass rs->mon as value, which
> should be initialized in readline_init() called by monitor_init().
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  include/monitor/readline.h |    3 ++-
>  monitor.c                  |   18 +++++++++---------
>  readline.c                 |    2 +-
>  3 files changed, 12 insertions(+), 11 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]