[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update
From: |
Gabriel Kerneis |
Subject: |
Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers |
Date: |
Tue, 23 Jul 2013 13:10:35 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jul 23, 2013 at 02:05:15PM +0200, Stefan Hajnoczi wrote:
> A built-time check for coroutine_fn would be valuable if we ever hope to
> get disciplined with this annotation.
>
> The check can detect when a coroutine_fn is invoked outside coroutine
> context. I wonder if Coccinelle can detect this, although I never
> figured out how to use it as a grep-like tool instead of just a
> patch-like tool.
The recent "cps-inference" branch of CPC enables precisely that kind of check.
Charlie is using it to drive his modifications to QEMU and has already suggested
several improvements that I have implemented. Hopefully we should reach
something fully covering QEMU by the end his GSoC.
If there is interest, I can post a script showing how to build it and use it to
check QEMU annotations (it does not require any modifications to QEMU, only a
couple of configure switches).
Best regards,
--
Gabriel
Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers, Wenchao Xia, 2013/07/24