Re: [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features

[Fam Zheng]

On Tue, 07/23 18:29, Benoît Canet wrote:
> The first patch fixes the throttling which was broken by a previous commit.
> 
> The next patch replace the existing throttling algorithm by the well described
> leaky bucket algorithm.
> 
> Third patch implement bursting by adding *_threshold parameters to
> qmp_block_set_io_throttle.
> 
> The last one allow to define the max size of an io when throttling by iops via
> iops_sector_count to avoid vm users cheating on the iops limit.
> 
> The last patch adds a metric reflecting how much the I/O are throttled.
> 
My ignorant question: Besides the fix, how is io throttling improved
from previously, what are the advantages of leaky bucket algorithm?

Thanks.

Fam