[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completio
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completion() |
Date: |
Thu, 25 Jul 2013 09:56:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> In order to support sub command in auto completion, an reentrant function
s/an/a/
> is needed, so monitor_find_completion() is splitted into two parts. The
s/splitted/split/
> first part does parsing of user input which need to be done only once,
> the second part does the auto completion job according to the parsing
> result, which contains the necessary code to support sub command and
> works as the reentrant function. The global "info_cmds" is still used
> in second part, which will be replaced by sub command code later.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> monitor.c | 65 ++++++++++++++++++++++++++++++++++++------------------------
> 1 files changed, 39 insertions(+), 26 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V7 05/13] monitor: avoid use of global *cur_mon in readline_completion(), (continued)
- [Qemu-devel] [PATCH V7 06/13] monitor: avoid direct use of global variable *mon_cmds, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 07/13] monitor: code move for parse_cmdline(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline(), Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 09/13] monitor: support sub command in help, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completion(), Wenchao Xia, 2013/07/19
- Re: [Qemu-devel] [PATCH V7 10/13] monitor: refine monitor_find_completion(),
Eric Blake <=
- [Qemu-devel] [PATCH V7 11/13] monitor: support sub command in auto completion, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 12/13] monitor: allow "help" show message for single command in sub group, Wenchao Xia, 2013/07/19
- [Qemu-devel] [PATCH V7 13/13] monitor: improve auto complete of "help" for single command in sub group, Wenchao Xia, 2013/07/19
- Re: [Qemu-devel] [PATCH V7 00/13] monitor: support sub command group in auto completion and help, Wenchao Xia, 2013/07/24