[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command |
Date: |
Fri, 26 Jul 2013 20:14:06 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.07.2013 um 19:45 hat Eric Blake geschrieben:
> Overall, I like where this is headed, but I'm not quite sure it is ready
> for commit as-is; looking forward to v2. Given my positive review on
> the rest of the series, I think you could get away with a pull request
> on the front half of the series and only respinning this patch, instead
> of needing (re-)review of the entire series.
Yup, that's exactly what I'm going to do now. I had considered merging
the whole series, but I think you're right that committing it now might
be a bit early. My main concern were potential conflicts in the front
"half" (17/18) of the series when I'd wait too long with committing.
I'll reply in more detail to your other points later today or on Monday.
Kevin
- Re: [Qemu-devel] [PATCH 15/18] blockdev: Rename 'readonly' option to 'read-only', (continued)