|
From: | Frediano Ziglio |
Subject: | Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly. |
Date: | Sun, 28 Jul 2013 17:56:01 +0100 |
Hi,
> Tested-by: Fabio Fantoni <address@hidden>
>
> I tested it for a long time with spice on xen (because qxl will be fully
> working only after adding SSE support on hvm domUs). It works, I think
> it is good to add this and the respective vgabios patch on upstream.
>> case VBE_DISPI_INDEX_XRES:It's not that simple. With 32bit depths common today it will work fine,
>> - if ((val <= VBE_DISPI_MAX_XRES) && ((val & 7) == 0)) {
>> + if ((val <= VBE_DISPI_MAX_XRES) && ((val & 1) == 0)) {
>> s->vbe_regs[s->vbe_index] = val;
>> }
>> break;
but for lower depths (especially those lower than 8bit) this will give
you broken scanline alignment.
cheers,
Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |