Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

[Andreas Färber]

Am 31.07.2013 13:20, schrieb Stefan Hajnoczi:
> On Wed, Jul 31, 2013 at 12:19:06PM +0200, Vincenzo Maffione wrote:
>> Sorry, I'm not confident with this infrastructure.
> 
> Thanks for your efforts!  Normally this change would not be necessary
> but you are the first person who needs a 1.6 compat property :).
> 
>> So do you just want me to invert the commit order? (and do the other
>> two little changes)
> 
> Yes, please introduce an empty PC_COMPAT_1_6 in Patch 1 and then make
> use of it for e1000 interrupt mitigation in Patch 2.  That way creating
> PC_COMPAT_1_6 is an independent commit which can be cherry-picked and
> reused independently of e1000 interrupt mitigation.

Add to that, the patch needs to be amended to actually add 1.7 machines
for i440fx and q35, moving the .alias there instead of on the 1.6
machines. Otherwise mitigation will always be disabled. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg