Re: [Qemu-devel] [PATCH 2/2] i82378: cleanup implementation

[Hervé Poussineau]

Andreas Färber a écrit :
> Am 23.07.2013 23:16, schrieb Hervé Poussineau:
> > diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c
> > index de71d81..f2045de 100644
> > --- a/hw/isa/i82378.c
> > +++ b/hw/isa/i82378.c
> [...]
> > -static const VMStateDescription vmstate_pci_i82378 = {
> > -    .name = "pci-i82378",
> > +static const VMStateDescription vmstate_i82378 = {
> > +    .name = "i82378",
> >      .version_id = 0,
> >      .minimum_version_id = 0,
> >      .fields = (VMStateField[]) {
> > -        VMSTATE_PCI_DEVICE(pci_dev, PCIi82378State),
> > +        VMSTATE_PCI_DEVICE(parent_obj, I82378State),
> >          VMSTATE_END_OF_LIST()
> >      },
> >  };
> [snip]
>
> Renaming the section would break backwards compatibility, we'll need to
> live with that name.

Not a problem.
Or, you can update version_id and minimum_version_id to 1, and ignore 
backward compatibility problems, as i82378 is only used in PPC machine 
by default.
Do as you want.

Hervé