[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDrive
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState |
|
Date: |
Fri, 2 Aug 2013 17:06:13 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Aug 02, 2013 at 10:22:13AM +0800, Fam Zheng wrote:
> On Thu, 08/01 14:28, Stefan Hajnoczi wrote:
> > On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote:
> > Follow-up question:
> >
> > Did you look at using bdrv_ref() for the BDS <- BlockJob relationship
> > too?
> >
> > blockdev.c block job code still uses the DriveInfo refcount after your
> > series. The BDS reference would be sufficient since the DriveInfo
> > fields are not used by block jobs.
> >
> For now they coexist, which works but with redundancy. I will send
> follow-up patch(es) to clean up block job to only use BDS refcount.
Wenchao's review comment pointed out the case where block job
termination will segfault if DriveInfo has been deleted. I think this
needs to be address together with these patches instead of later.
Stefan