[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk header fields |
Date: |
Tue, 6 Aug 2013 11:42:47 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 08/05 23:30, Jeff Cody wrote:
> On Tue, Aug 06, 2013 at 09:40:36AM +0800, Fam Zheng wrote:
> > The size and offset fields are all non-negative values, use uint64_t for
> > them to avoid getting negative in memory value by int overflow.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block/vmdk.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/block/vmdk.c b/block/vmdk.c
> > index 7ebe36b..976b871 100644
> > --- a/block/vmdk.c
> > +++ b/block/vmdk.c
> > @@ -67,14 +67,14 @@ typedef struct {
> > typedef struct {
> > uint32_t version;
> > uint32_t flags;
> > - int64_t capacity;
> > - int64_t granularity;
> > - int64_t desc_offset;
> > - int64_t desc_size;
> > - int32_t num_gtes_per_gte;
> > - int64_t rgd_offset;
> > - int64_t gd_offset;
> > - int64_t grain_offset;
> > + uint64_t capacity;
> > + uint64_t granularity;
> > + uint64_t desc_offset;
>
> desc_offset in BDRVVmdkState should be uint64_t as well, right?
Yes, will fix.
>
> > + uint64_t desc_size;
> > + uint32_t num_gtes_per_gte;
> > + uint64_t rgd_offset;
> > + uint64_t gd_offset;
> > + uint64_t grain_offset;
> > char filler[1];
> > char check_bytes[4];
> > uint16_t compressAlgorithm;
> > --
> > 1.8.3.4
> >
--
Fam
- [Qemu-devel] [PATCH v3 00/10] vmdk: Input validation fixes, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 01/10] vmdk: Make VMDK3Header QEMU_PACKED, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 02/10] vmdk: Make VmdkGrainMarker QEMU_PACKED, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk header fields, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 04/10] qemu-iotests: add poke_file utility function, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 05/10] qemu-iotests: add empty test case for vmdk, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 06/10] vmdk: check granularity field in opening, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 07/10] vmdk: check l2 table size when opening, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 08/10] vmdk: check l1 size before opening image, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 09/10] vmdk: use heap allocation for whole_grain, Fam Zheng, 2013/08/05
- [Qemu-devel] [PATCH v3 10/10] vmdk: rename num_gtes_per_gte to num_gtes_per_gt, Fam Zheng, 2013/08/05
- Re: [Qemu-devel] [PATCH v3 00/10] vmdk: Input validation fixes, Stefan Hajnoczi, 2013/08/06