[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer. |
Date: |
Thu, 08 Aug 2013 17:30:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Il 08/08/2013 16:29, Benoît Canet ha scritto:
> tip: Do not ever use the cfg scheduler in the guest with this code.
> It gives incorrect throttling.
This is not really accurate; the cfq scheduler reorders reads and writes
to have longer bursts, and these sometimes exceed the rate you set. I
understood this is mostly for separate rd/wr settings, or did you
reproduce it with "total" rates too?
Also, it would be better to have a workaround for this. Perhaps we
could simply make the default value of max nonzero? In the old
throttling code the slice time is 0.1s, so perhaps we could see what
happens with max=0.1*avg.
Paolo
- [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling, Benoît Canet, 2013/08/08
- [Qemu-devel] [PATCH V4 1/5] throttle: Add a new t hrottling API implementing continuous leaky bucket., Benoît Canet, 2013/08/08
- [Qemu-devel] [PATCH V4 2/5] throttle: Add units t ests, Benoît Canet, 2013/08/08
- [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer., Benoît Canet, 2013/08/08
- Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.,
Paolo Bonzini <=
- [Qemu-devel] [PATCH V4 4/5] block: Add support fo r throttling burst max in QMP and the command line., Benoît Canet, 2013/08/08
- [Qemu-devel] [PATCH V4 5/5] block: Add iops_sec tor_count to do the iops accounting for a given io siz e., Benoît Canet, 2013/08/08
- Re: [Qemu-devel] [PATCH V4 0/5] Continuous Leaky Bucket Throttling*, Benoît Canet, 2013/08/09