Re: [Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add aio_timer_new wrapper

[Paolo Bonzini]

Il 08/08/2013 23:42, Alex Bligh ha scritto:
> Add aio_timer_new wrapper function.
> 
> Signed-off-by: Alex Bligh <address@hidden>
> ---
>  include/block/aio.h |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/include/block/aio.h b/include/block/aio.h
> index a13f6e8..bd6f17c 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -255,4 +255,23 @@ void qemu_aio_set_fd_handler(int fd,
>                               void *opaque);
>  #endif
>  
> +/**
> + * aio_timer_new:
> + * @ctx: the aio context
> + * @type: the clock type
> + * @scale: the scale
> + * @cb: the callback to call on timer expiry
> + * @opaque: the opaque pointer to pass to the callback
> + *
> + * Generate a new timer attached to the context @ctx.
> + *
> + * Returns: a pointer to the new timer
> + */
> +static inline QEMUTimer *aio_timer_new(AioContext *ctx, QEMUClockType type,
> +                                       int scale,
> +                                       QEMUTimerCB *cb, void *opaque)
> +{
> +    return timer_new(ctx->tlg[type], scale, cb, opaque);
> +}

Since we're doing a new API, I would prefer to have it as timer_init and
aio_timer_init.  We can remove the allocation completely, it is a
useless indirection and we misuse it since we hardly ever call
qemu_free_timer.

Paolo

>  #endif
>