Re: [Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

[Andreas Färber]

Am 14.08.2013 13:03, schrieb Edgar E. Iglesias:
> On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote:
>> Then let's make the logic work like this:
>>
>> if (user provided -dtb) {
>>   if (load_dtb(user provided dtb)) {
>>     abort();
>>   }
>> } else {
>>   if (load_dtb("ppc.dtb")) {
>>     if (load_dtb(find_file(BINARY_DEVICE_TREE_FILE))) {
>>       abort();
>>     }
>>   }
>> }
> 
> Hi Alex,
> 
> I think that we should only abort() on the -dtb arg case.

Don't abort() on user-supplied arguments, they're for programmer errors.

Also since Alex has been on vacation, please note that we have a shiny
error_report() function that should be preferred over any
fprintf(stderr, ...). :) Only downside is it seems to require its own
#include. :/

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg