Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

[Andreas Färber]

Am 20.08.2013 15:46, schrieb Peter Maydell:
> On 5 August 2013 02:27, Peter Chubb <address@hidden> wrote:
>>
>> When imx_epit.c was last refactored, a common usecase (comparison
>> register zero) broke.  This patch fixes that, and simplifies the code
>> yet more.  It also fixes a major thinko in the reset path --- the
>> wrong bits in the control register were being cleared.
>>
>> Signed-off-by: Peter Chubb <address@hidden>
>> Reviewed-by: Jean-Christophe DUBOIS <address@hidden>
> 
> Thanks; applied to target-arm.next.

Peter Ch., please call such a patch "imx_epit: " rather than "ARM: "
since it affects only your device. (PMM, can you fix?)

Also if there is a reset bug, then fixing that in its own patch would
better allow backporting that to 1.6.1. The way it is right now with no
Cc: line for qemu-stable, the released version will keep the thinko.
Changing debug output from stdout to stderr would've also been a change
of its own that is not even mentioned in the commit message.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg