[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check |
Date: |
Mon, 26 Aug 2013 15:15:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Hi,
On Mon, Aug 26, 2013 at 15:04 +0200, Max Reitz wrote:
Adds a new function checking for overlapping cluster allocations.
Furthermore, qcow2_check now marks the image as consistent if no
corruptions have been found.
Signed-off-by: Max Reitz <address@hidden>
Such overlappings are often (if not always) found by the refcount checks
as well. By increasing the refcount of the clusters affected and
therefore enforcing COW, the collision is basically fixed as well
without requiring this new function.
Thus I'm not sure whether this new function is actually necessary since
the existing refcount check seems to cover all its functionality already.
But, well, I thought it couldn't hurt proposing this function at least. ;-)
Kind regards,
Max
[Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check, Max Reitz, 2013/08/26
[Qemu-devel] [PATCH 0/5] qcow2: Add metadata overlap checks, Max Reitz, 2013/08/26
- [Qemu-devel] [PATCH 1/5] qcow2: Add corrupt bit, Max Reitz, 2013/08/26
- [Qemu-devel] [PATCH 2/5] qcow2: Metadata overlap checks, Max Reitz, 2013/08/26
- [Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check, Max Reitz, 2013/08/26
- [Qemu-devel] [PATCH 3/5] qcow2: Employ metadata overlap checks, Max Reitz, 2013/08/26
- [Qemu-devel] [PATCH 5/5] qemu-iotests: Overlapping cluster allocations, Max Reitz, 2013/08/26
- Re: [Qemu-devel] [PATCH 0/5] qcow2: Add metadata overlap checks, Max Reitz, 2013/08/26