[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for v1.6] pc: Fix initialization of the ram_memo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for v1.6] pc: Fix initialization of the ram_memory variable. |
Date: |
Thu, 29 Aug 2013 11:00:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 16/08/2013 16:46, Anthony PERARD ha scritto:
> In some cases (Xen), it will not be initialized before to be used. This
> leads to segv.
>
> Signed-off-by: Anthony PERARD <address@hidden>
>
> ---
>
> It works with this simple initialization to NULL, but would it be
> necessary (or better) to assign a proper value to this variables ?
Yeah, the right value of this variable comes from xen_ram_init (called
by xen_hvm_init).
Paolo
> ---
> hw/i386/pc_piix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 6e1e654..596d433 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -86,7 +86,7 @@ static void pc_init1(MemoryRegion *system_memory,
> BusState *idebus[MAX_IDE_BUS];
> ISADevice *rtc_state;
> ISADevice *floppy;
> - MemoryRegion *ram_memory;
> + MemoryRegion *ram_memory = NULL;
> MemoryRegion *pci_memory;
> MemoryRegion *rom_memory;
> DeviceState *icc_bridge;
>