[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 4/6] qmp: add 'cpu-del' command support
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 4/6] qmp: add 'cpu-del' command support |
Date: |
Thu, 29 Aug 2013 06:28:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/28/2013 08:09 PM, Chen Fan wrote:
> Signed-off-by: Chen Fan <address@hidden>
> ---
> hw/i386/pc.c | 5 +++++
> hw/i386/pc_piix.c | 1 +
> include/hw/boards.h | 2 ++
> include/hw/i386/pc.h | 1 +
> qapi-schema.json | 12 ++++++++++++
> qmp-commands.hx | 23 +++++++++++++++++++++++
> qmp.c | 9 +++++++++
> 7 files changed, 53 insertions(+)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index c0e7cbd..75fc9bb 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -958,6 +958,11 @@ void pc_hot_add_cpu(const int64_t id, Error **errp)
> pc_new_cpu(current_cpu_model, apic_id, icc_bridge, errp);
> }
>
> +void pc_hot_del_cpu(const int64_t id, Error **errp)
> +{
> + /* TODO: hot remove VCPU. */
> +}
That seems fishy.
> +++ b/qapi-schema.json
> @@ -1432,6 +1432,18 @@
> ##
> { 'command': 'cpu-add', 'data': {'id': 'int'} }
>
> +# @cpu-del
> +
> +# Deletes CPU with specified ID
> +#
> +# @id: ID of CPU to be deleted, valid values [0..max_cpus)
> +#
> +# Returns: Nothing on success
> +#
> +# Since 1.6
1.6 is already out the door. This must be 1.7.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC][PATCH 0/6] i386: add cpu hot remove support, Chen Fan, 2013/08/28
- [Qemu-devel] [RFC][PATCH 2/6] cpus: release allocated vcpu objects and exit vcpu thread, Chen Fan, 2013/08/28
- [Qemu-devel] [RFC][PATCH 4/6] qmp: add 'cpu-del' command support, Chen Fan, 2013/08/28
- Re: [Qemu-devel] [RFC][PATCH 4/6] qmp: add 'cpu-del' command support,
Eric Blake <=
- [Qemu-devel] [RFC][PATCH 3/6] qom cpu: rename variable 'cpu_added_notifier' to 'cpu_hotplug_notifier', Chen Fan, 2013/08/28
- [Qemu-devel] [RFC][PATCH 1/6] piix4: implement function 'cpu_status_write' for vcpu ejection, Chen Fan, 2013/08/28
- [Qemu-devel] [RFC][PATCH 5/6] qom cpu: add struct CPUNotifier for supporting PLUG and UNPLUG cpu notifier, Chen Fan, 2013/08/28
- [Qemu-devel] [RFC][PATCH 6/6] i386: implement cpu interface 'cpu_common_unrealizefn', Chen Fan, 2013/08/28