Re: [Qemu-devel] [PATCH 7/8] spapr vfio: add spapr-pci-vfio-host-bridge to support vfio

[Andreas Färber]

Am 30.08.2013 09:43, schrieb Alexey Kardashevskiy:
> On 08/27/2013 09:08 PM, Alexander Graf wrote:
>>> type_init(register_types);
>>> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
>>> index 869ca43..3f37cac 100644
>>> --- a/hw/ppc/spapr_pci.c
>>> +++ b/hw/ppc/spapr_pci.c
>>
>> I think we should move the vfio phb into a separate file and make it be a 
>> proper subclass without even the chance to randomly call normal spapr pci 
>> functions ;).
>>
>> Andreas, could you please check through this and see if you can spot a way 
>> to isolate it out?

Just noticing this question now... (me not so into reviewing VFIO)

> After the lesson you both gave me with xics/xics-kvm, I am (more or less)
> aware of what I need to change here so wait a bit till I post another version.

Thanks.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg