[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize inst
From: |
Antony Pavlov |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init |
Date: |
Sun, 1 Sep 2013 22:28:06 +0400 |
On Sat, 31 Aug 2013 21:09:20 +0200
Andreas Färber <address@hidden> wrote:
> Am 31.08.2013 19:22, schrieb Antony Pavlov:
> > Use of SysBusDevice::init is deprecated.
> > Use Device::realize instead of SysBusDevice::init.
> > Check dma/pl330.c for an example of the pattern.
> >
> > Also introduce TypeInfo::instance_init milkymist_uart_init()
> > as char/pl011.c does.
> >
> > Reported-by: Peter Crosthwaite <address@hidden>
> > Signed-off-by: Antony Pavlov <address@hidden>
> > CC: Peter Crosthwaite <address@hidden>
> > CC: Michael Walle <address@hidden>
> > CC: Andreas Färber <address@hidden>
> > ---
> > hw/char/milkymist-uart.c | 24 ++++++++++++++----------
> > 1 file changed, 14 insertions(+), 10 deletions(-)
>
> Thanks, applied to qom-next (with shortened commit message):
> https://github.com/afaerber/qemu-cpu/commits/qom-next
>
That's about the patch number 1 ( milkymist-uart: use qemu_chr_fe_write_all()
instead of qemu_chr_fe_write()) ?
--
Best regards,
Antony Pavlov
- Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init,
Antony Pavlov <=