qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCHv2] Make usb-bt-dongle configurable
Date: Tue, 03 Sep 2013 13:33:41 +0200

> > This (and some other bits) are pure code motion from vl.c, correct?
> > Can you split this into a separate patch please?  That'll simplify the
> > review o the actual code changes.
> 
> Yes, this is pure code motion. I'll split the code to separate patches.
> > 
> > It also doesn't make much sense to compile hw/bt/ with
> > CONFIG_USB_BLUETOOTH=n.  It's basically dead code then.
> > 
> 
> Is this true? So -bt option is not useable without usb-bt-dongle? 

Ahem, well, double-checked:  No.

n800+n810 emulation (qemu-system-arm) has a bluetooth hci too.

So we need a separate CONFIG_BLUETOOTH for hw/bt/, so we can enable it
for both arm emulation and for CONFIG_USB_BLUETOOTH=y.  Maybe it makes
sense to wait until we have kconfig.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]