[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH] kvm: fix traces to use %x instead of %d |
Date: |
Wed, 04 Sep 2013 01:44:15 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 09/03/2013 07:47 PM, Andreas Färber wrote:
> Am 03.09.2013 08:43, schrieb Alexey Kardashevskiy:
>> KVM request types are normally defined using hex constants but QEMU traces
>> print decimal values instead what is not very convinient.
>
> "which is", "convenient" -- pointing it out early since the KVM guys
> don't fix patches once in their queue.
Sorry, I did not get this. There is a patch like me in a queue?
> Patch itself:
>
> Reviewed-by: Andreas Färber <address@hidden>
Thanks!
> Andreas
>
>>
>> This changes the request type format from %d to %x.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>> trace-events | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/trace-events b/trace-events
>> index 4574f29..24cf4d2 100644
>> --- a/trace-events
>> +++ b/trace-events
>> @@ -1171,9 +1171,9 @@ virtio_ccw_new_device(int cssid, int ssid, int schid,
>> int devno, const char *dev
>> migrate_set_state(int new_state) "new state %d"
>>
>> # kvm-all.c
>> -kvm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
>> -kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d,
>> arg %p"
>> +kvm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vm_ioctl(int type, void *arg) "type %x, arg %p"
>> +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %x,
>> arg %p"
>> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>>
>> # memory.c
>>
>
>
--
Alexey