Re: [Qemu-devel] [PATCH] ne2000: mark I/O as LITTLE_ENDIAN

[Stefan Hajnoczi]

On Mon, Sep 02, 2013 at 01:10:34PM +0200, Aurelien Jarno wrote:
> Now that the memory subsystem is propagating the endianness correctly,
> the ne2000 device should have its I/O ports marked as LITTLE_ENDIAN, as
> PCI devices are little endian.
> 
> This makes the ne2000 NIC to work again on PowerPC.
> 
> Cc: address@hidden
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  hw/net/ne2000.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
> index 31afd28..c961258 100644
> --- a/hw/net/ne2000.c
> +++ b/hw/net/ne2000.c
> @@ -693,7 +693,7 @@ static void ne2000_write(void *opaque, hwaddr addr,
>  static const MemoryRegionOps ne2000_ops = {
>      .read = ne2000_read,
>      .write = ne2000_write,
> -    .endianness = DEVICE_NATIVE_ENDIAN,
> +    .endianness = DEVICE_LITTLE_ENDIAN,
>  };

This is also used by hw/net/ne2000-isa.c:isa_ne2000_realizefn().  Is it
correct to explicitly say little-endian there?