[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 1/6] bdrv: Use "Error" for opening images
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [RFC v2 1/6] bdrv: Use "Error" for opening images |
Date: |
Fri, 6 Sep 2013 15:36:20 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 05.09.2013 um 15:55 hat Max Reitz geschrieben:
> Add an Error ** parameter to BlockDriver.bdrv_open and
> BlockDriver.bdrv_file_open to allow more specific error messages.
>
> Signed-off-by: Max Reitz <address@hidden>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 2bbee1f..2464f19 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1046,7 +1046,8 @@ static QemuOptsList runtime_opts = {
> * We support iscsi url's on the form
> * iscsi://[<username>%<password>@]<host>[:<port>]/<targetname>/<lun>
> */
> -static int iscsi_open(BlockDriverState *bs, QDict *options, int flags)
> +static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
> + Error **errp)
> {
> IscsiLun *iscsilun = bs->opaque;
> struct iscsi_context *iscsi = NULL;
block/iscsi.c: In function 'iscsi_create':
block/iscsi.c:1265:5: error: too few arguments to function 'iscsi_open'
block/iscsi.c:1049:12: note: declared here
- [Qemu-devel] [RFC v2 0/6] block: Error parameter for opening/creating images, Max Reitz, 2013/09/05
- [Qemu-devel] [RFC v2 1/6] bdrv: Use "Error" for opening images, Max Reitz, 2013/09/05
- [Qemu-devel] [RFC v2 2/6] bdrv: Use "Error" for creating images, Max Reitz, 2013/09/05
- [Qemu-devel] [RFC v2 3/6] block: Error parameter for open functions, Max Reitz, 2013/09/05
- [Qemu-devel] [RFC v2 4/6] block: Error parameter for create functions, Max Reitz, 2013/09/05
- [Qemu-devel] [RFC v2 5/6] qcow2: Use Error parameter, Max Reitz, 2013/09/05
- [Qemu-devel] [RFC v2 6/6] bdrv: No silent error message discarding, Max Reitz, 2013/09/05