Re: [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox

[Stefan Weil]

Am 09.09.2013 19:32, schrieb Aurelien Jarno:
> On Wed, Sep 04, 2013 at 11:35:27AM +0400, Antony Pavlov wrote:
>> @@ -0,0 +1,48 @@
>> +/*
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.      See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; if not, write to the Free Software
>> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307     
>>  USA
>> + */
>> +/*  Size defintions

Is this the original comment? Then someone should send them a fix :-)

>> + *  Copyright (C) ARM Limited 1998. All rights reserved.
>> + */
>> +
>> +#ifndef __sizes_h
>> +#define __sizes_h                   1
> I think this should be in upper case, prefixed with QEMU_ or _QEMU.
>
>> +
>> +/* handy sizes */
>> +#define SZ_1K                               0x00000400
>> +#define SZ_4K                               0x00001000
>> +#define SZ_8K                               0x00002000

What about replacing all tabs to spaces before importing code to QEMU?
This improves QEMU compatibility without requiring too much additional
efforts during initial import and later updates.

I'd really appreciate that.

Stefan