[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/7] tcg-ppc: Fix and cleanup tcg_out_tlb_che
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 7/7] tcg-ppc: Fix and cleanup tcg_out_tlb_check |
Date: |
Mon, 09 Sep 2013 17:33:21 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/09/2013 05:28 PM, Richard Henderson wrote:
> + if (add_off >= 0x8000) {
> + /* Most target env are smaller than 32k; none are larger than 64k.
> + Simplify the logic here merely to offset by 0x8000, giving us a
> + range just shy of 64k. Check this assumption. */
> + QEMU_BUILD_BUG_ON(offsetof(CPUArchState,
> + tlb_table[NB_MMU_MODES - 1][1])
> + > 0x8000 + 0x7fff);
> + tcg_out32(s, ADDI | RT(r1) | RA(base) | 0x8000);
> + base = r1;
> + cmp_off -= 0x8000;
> + add_off -= 0x8000;
And of course this is wrong, because 0x8000 == -0x8000.
I've fixed this more than once on my branches. How do I keep
managing to lose that fix?
- [Qemu-devel] [PATCH v2 0/7] tcg-ppc qemu_ldst improvements, Richard Henderson, 2013/09/09
- [Qemu-devel] [PATCH v2 3/7] configure: Allow command-line configure for ppc32, Richard Henderson, 2013/09/09
- [Qemu-devel] [PATCH v2 4/7] tcg-ppc: Avoid code for nop move, Richard Henderson, 2013/09/09
- [Qemu-devel] [PATCH v2 6/7] tcg-ppc: Use conditional branch and link to slow path, Richard Henderson, 2013/09/09
- [Qemu-devel] [PATCH v2 5/7] tcg-ppc: Cleanup tcg_out_qemu_ld/st_slow_path, Richard Henderson, 2013/09/09
- [Qemu-devel] [PATCH v2 1/7] tcg-ppc: fix qemu_ld/qemu_st for AIX ABI, Richard Henderson, 2013/09/09
- [Qemu-devel] [PATCH v2 2/7] tcg-ppc: use new return-argument ld/st helpers, Richard Henderson, 2013/09/09
- [Qemu-devel] [PATCH v2 7/7] tcg-ppc: Fix and cleanup tcg_out_tlb_check, Richard Henderson, 2013/09/09
- Re: [Qemu-devel] [PATCH v2 0/7] tcg-ppc qemu_ldst improvements, Paolo Bonzini, 2013/09/10