Re: [Qemu-devel] [PATCH] tci: Detect function argument alignment

[Peter Maydell]

On 12 September 2013 20:45, Stefan Weil <address@hidden> wrote:
> +else
> +
> +  # Cross compilation, so we cannot launch a program. Require configure 
> argument.
> +  error_exit "Unknown function argument alignment" \
> +             "The TCG interpreter must know the alignment of function 
> arguments." \
> +             "Configure cannot determine the alignment because this is a 
> cross build," \
> +             "so please add --enable-call-align-args or 
> --disable-call-align-args."
> +
> +fi

No new configure tests which can't cope with cross compilation,
please.

> +#if defined(CONFIG_CALL_ALIGN_ARGS)
> +# define TCG_TARGET_CALL_ALIGN_ARGS     1
> +#endif

You're not a native assembly backend, you can't rely on this
to be sufficient. Use libffi or call the target function with
the exact correct prototype.

-- PMM