Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading function

[Fam Zheng]

On Fri, 09/13 10:56, Alex Bligh wrote:
> 
> On 13 Sep 2013, at 09:38, Fam Zheng wrote:
> 
> > Added three types of modules:
> > 
> >    typedef enum {
> >        MODULE_LOAD_BLOCK = 0,
> >        MODULE_LOAD_UI,
> >        MODULE_LOAD_NET,
> >        MODULE_LOAD_MAX,
> >    } module_load_type;
> > 
> > and their loading function:
> 
> What is the advantage of this enum and having
> different types of module at all? If they are
> all built together, why can't they all live
> together in the same directory?
> 
> Seems like an overcomplication.
> 

They anyway need to be grouped: block drivers are almost always loaded, but not
ui, or net (although they're not modulized in this series), and they shouldn't
be loaded, from example by qemu-img, because of missing necessary functions.
For this reason, I don't think subdirecotry is an overcomplication over file
name prefix/postfix, or arrays of file name lists.

Fam