Re: [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes

[Richard Henderson]

On 09/13/2013 12:33 AM, Antony Pavlov wrote:
> Changes since v2:
>  * commit messages: drop ALL 'Reviewed-by' tags.
>  Drop Aurelien Jarno's tag because the patchseries
>  was completely reworked, so it need additional review.
> 
> Changes since v1:
> 
>  * include/sizes.h -> include/qemu/sizes.h
>  * fix copyright header;
>  * fix formatting: drop tabs;
>  * use the BIT() macro, so it's easy-to-read the constants column;
>  also the BIT() macro casts constant to UL;
>  * rebase on updated master;
>  * take into account the "mips_malta: support up to 2GiB RAM" commit.
> 
> [RFC v3 1/2] include/qemu: introduce sizes.h
> [RFC v3 2/2] hw/mips: use sizes.h macros
> 
> The sizes.h macros is a easy-to-read method of
> power-of-two memory sizes representation. The sizes.h
> macros are actively used in linux kernel and other
> projects, so let's use them in QEMU too.
> 

Seems reasonable.  I'd have said why bother with some of
the multiples, except for the crossover with the linux kernel.

Reviewed-by: Richard Henderson <address@hidden>


r~