[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading |
Date: |
Mon, 16 Sep 2013 12:09:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 16/09/2013 11:51, Fam Zheng ha scritto:
> On Mon, 09/16 11:44, Paolo Bonzini wrote:
>> Il 16/09/2013 10:59, Daniel P. Berrange ha scritto:
>>>> The init function of dynamic module is no longer with
>>>> __attribute__((constructor)) as static linked version, and need to be
>>>> explicitly called once loaded. The function name is mangled with per
>>>> configure fingerprint as:
>>>>
>>>> init_$(date +%s$$$RANDOM)
>>
>> Does this work for a module that calls module_init multiple times?
>
> Why should a module calls module_init, instead of the main function?
I think you mean "why should a module calls register_module_init", and I
agree that with this patch a module will not call register_module_init.
But a module is still using the module_init macro.
With this patch, a module will not be able to use the module_init macro
twice. I am not sure this is an acceptable limitation, especially if we
do not have a dependency system within modules and/or load them with
G_MODULE_LOCAL/RTLD_LOCAL.
Paolo
> This name is generated per "./configure", not per object or per make, so it's
> essentially the same with any fixed function name, except for two objects
> built
> from two different "./configure" (which is the purpose for the mangling here).
>
> Does this answer your question?
>
> Fam
>
- [Qemu-devel] [PATCH v10 2/8] make.rule: fix $(obj) to a real relative path, (continued)
- [Qemu-devel] [PATCH v10 2/8] make.rule: fix $(obj) to a real relative path, Fam Zheng, 2013/09/16
- [Qemu-devel] [PATCH v10 3/8] rule.mak: allow per object cflags and libs, Fam Zheng, 2013/09/16
- [Qemu-devel] [PATCH v10 4/8] build-sys: introduce common-obj-m and block-obj-m for DSO, Fam Zheng, 2013/09/16
- [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Fam Zheng, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Paolo Bonzini, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Fam Zheng, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Daniel P. Berrange, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Paolo Bonzini, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Daniel P. Berrange, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Paolo Bonzini, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Fam Zheng, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Paolo Bonzini, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Fam Zheng, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Richard Henderson, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Fam Zheng, 2013/09/16
- Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading, Richard Henderson, 2013/09/17