qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize
Date: Tue, 17 Sep 2013 19:16:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

Il 17/09/2013 19:07, Michael S. Tsirkin ha scritto:
> After memory_region_del_subregion returns,
> it's a promise that there will not be accesses
> to the region.

It's racy anyway.  You can have memory_region_del_subregion happen one
clock cycle after the other (physical) CPU has done checked that there
will not be accesses to the region.

A real bus has a "big PCI lock" (there can be only one transaction at a
time), which is exactly what we want to get rid of.

> So I'm not even sure we really need to move destroy to finalize anymore ...

We definitely need to move it.  Even if we added a flag that we set in
memory_region_del_subregion, we need to check it later when AIO completes.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]