[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 2/4] qemu-nbd: support internal snapshot expo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V2 2/4] qemu-nbd: support internal snapshot export |
Date: |
Tue, 24 Sep 2013 10:11:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 24/09/2013 04:56, Wenchao Xia ha scritto:
> δΊ 2013/9/23 18:25, Paolo Bonzini ει:
>> Il 22/09/2013 11:39, Wenchao Xia ha scritto:
>>> Now it is possible to directly export an internal snapshot, which
>>> can be used to probe the snapshot's contents without qemu-img
>>> convert.
>>>
>>> Signed-off-by: Wenchao Xia<address@hidden>
>>> ---
>>> qemu-nbd.c | 54
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>> 1 files changed, 53 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/qemu-nbd.c b/qemu-nbd.c
>>> index c26c98e..e450d04 100644
>>> --- a/qemu-nbd.c
>>> +++ b/qemu-nbd.c
>>> @@ -20,6 +20,7 @@
>>> #include "block/block.h"
>>> #include "block/nbd.h"
>>> #include "qemu/main-loop.h"
>>> +#include "block/snapshot.h"
>>>
>>> #include<stdarg.h>
>>> #include<stdio.h>
>>> @@ -304,6 +305,23 @@ static void nbd_accept(void *opaque)
>>> }
>>> }
>>>
>>> +#define SNAPSHOT_OPT_ID "id"
>>> +#define SNAPSHOT_OPT_NAME "name"
>>> +
>>> +static QEMUOptionParameter snapshot_options[] = {
>>> + {
>>> + .name = SNAPSHOT_OPT_ID,
>>> + .type = OPT_STRING,
>>> + .help = "snapshot id"
>>> + },
>>> + {
>>> + .name = SNAPSHOT_OPT_NAME,
>>> + .type = OPT_STRING,
>>> + .help = "snapshot name"
>>> + },
>>> + { NULL }
>>> +};
>> I think whatever mechanism you use here to pick a snapshot id or name
>> should be implemented in qemu-img too.
> qemu-img already pick up snapshot by mixed id and name, do you like to
> add a new
> interface like the above(Keep old interface untouched for compatiablity)?
Yes, please. And also implement the "mixed" method here.
>> Also, I think QEMUOptionParameter is being phased out.
>>
> Is QemuOptsList the recommanded method?
Yes.
Paolo