[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of st
|
From: |
Riku Voipio |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64 |
|
Date: |
Tue, 24 Sep 2013 12:13:58 +0300 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Sep 23, 2013 at 09:05:03PM +0900, Peter Maydell wrote:
> On 23 September 2013 20:57, Riku Voipio <address@hidden> wrote:
> > On Thu, Sep 19, 2013 at 07:31:51PM +0200, Stefan Weil wrote:
> >> Ping? Are there any more opinions how qemu-sparc64 should be fixed?
> >> Should we choose Peter's approach (which is good, but with a
> >> higher risk than my patch)?
> >
> > I've included it now in my qeu, since it fixes qemu-sparc64 in my
> > smoketest and causes seemingly no regressions on other platforms.
> Yeah, but I bet there are other platforms we're not getting this
> right on since the #ifdef here isn't the same as the #ifdef that
> decides whether we have a target_stat64 struct or not...
Ok, I'll leave the patch on table then, and send this pullrequest
without it. Stefan, can you base the fix on setting
TARGET_NO_STRUCT_STAT64 when it is not available?
Riku