[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* a
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage |
Date: |
Tue, 24 Sep 2013 17:03:03 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Sep 23, 2013 at 02:45:13PM +0200, Stefan Hajnoczi wrote:
> On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote:
> > diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043
> > index 478773d..ae7cf27 100755
> > --- a/tests/qemu-iotests/043
> > +++ b/tests/qemu-iotests/043
> > @@ -31,7 +31,7 @@ status=1 # failure is the default!
> > _cleanup()
> > {
> > _cleanup_test_img
> > - rm -f $TEST_IMG.[123].base
> > + rm -f "$TEST_IMG.[123].base"
>
> This changes the semantics:
>
> $ touch a1 a2 a3
> $ echo a[123]
> a1 a2 a3
> $ echo "a[123]"
> a[123]
Yes, that should be "$TEST_IMG".[123].base instead.
- [Qemu-devel] [PATCH v2 0/3] qemu-iotests with sample images, vhdx test, cleanup, Jeff Cody, 2013/09/20
- [Qemu-devel] [PATCH v2 1/3] block: qemu-iotests - add basic ability to use binary sample images, Jeff Cody, 2013/09/20
- [Qemu-devel] [PATCH v2 2/3] block: qemu-iotests for vhdx, read sample dynamic image, Jeff Cody, 2013/09/20
- [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage, Jeff Cody, 2013/09/20
- Re: [Qemu-devel] [PATCH v2 0/3] qemu-iotests with sample images, vhdx test, cleanup, Stefan Hajnoczi, 2013/09/25