[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry o
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry options to drive_init |
Date: |
Tue, 01 Oct 2013 10:09:38 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 10/01/2013 07:20 AM, Kevin Wolf wrote:
> This moves all of the geometry options (cyls/heads/secs/trans) to
> drive_init so that they can only be accessed using legacy functions, but
> never with anything blockdev-add related.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 136
> +++++++++++++++++++++++++++++++------------------------------
> 1 file changed, 69 insertions(+), 67 deletions(-)
>
> + },{
> + .name = "trans",
> + .type = QEMU_OPT_STRING,
> + .help = "chs translation (auto, lba. none)",
s/lba\./lba,/
> - },{
> - .name = "trans",
> - .type = QEMU_OPT_STRING,
> - .help = "chs translation (auto, lba. none)",
Of course, that's just a code motion of an existing typo. And trivial
enough that it can be fixed by the maintainer without a respin.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 02/17] qapi-types/visit.py: Inheritance for structs, (continued)
- [Qemu-devel] [PATCH v2 04/17] blockdev: 'blockdev-add' QMP command, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 06/17] blockdev: Pass QDict to blockdev_init(), Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 05/17] blockdev: Separate ID generation from DriveInfo creation, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 10/17] blockdev: Move parsing of 'boot' option to drive_init, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry options to drive_init, Kevin Wolf, 2013/10/01
- Re: [Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry options to drive_init,
Eric Blake <=
- [Qemu-devel] [PATCH v2 11/17] blockdev: Move bus/unit/index processing to drive_init, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 12/17] blockdev: Move virtio-blk device creation to drive_init, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 13/17] blockdev: Remove IF_* check for read-only blockdev_init, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 03/17] blockdev: Introduce DriveInfo.enable_auto_del, Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 15/17] blockdev: Remove 'media' parameter from blockdev_init(), Kevin Wolf, 2013/10/01
- [Qemu-devel] [PATCH v2 16/17] blockdev: Don't disable COR automatically with blockdev-add, Kevin Wolf, 2013/10/01