[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH -V4 RESEND 1/6] target-ppc: Update slb array with co
From: |
Aneesh Kumar K.V |
Subject: |
[Qemu-devel] [PATCH -V4 RESEND 1/6] target-ppc: Update slb array with correct index values. |
Date: |
Tue, 1 Oct 2013 21:49:28 +0530 |
From: "Aneesh Kumar K.V" <address@hidden>
Without this, a value of rb=0 and rs=0 results in replacing the 0th
index. This can be observed when using gdb remote debugging support.
(gdb) x/10i do_fork
0xc000000000085330 <do_fork>: Cannot access memory at address
0xc000000000085330
(gdb)
This is because when we do the slb sync via kvm_cpu_synchronize_state,
we overwrite the slb entry (0th entry) for 0xc000000000085330
Signed-off-by: Aneesh Kumar K.V <address@hidden>
---
target-ppc/kvm.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 8a196c6..e318250 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1033,9 +1033,22 @@ int kvm_arch_get_registers(CPUState *cs)
/* Sync SLB */
#ifdef TARGET_PPC64
+ /*
+ * The packed SLB array we get from KVM_GET_SREGS only contains
+ * information about valid entries. So we flush our internal
+ * copy to get rid of stale ones, then put all valid SLB entries
+ * back in.
+ */
+ memset(env->slb, 0, sizeof(env->slb));
for (i = 0; i < 64; i++) {
- ppc_store_slb(env, sregs.u.s.ppc64.slb[i].slbe,
- sregs.u.s.ppc64.slb[i].slbv);
+ target_ulong rb = sregs.u.s.ppc64.slb[i].slbe;
+ target_ulong rs = sregs.u.s.ppc64.slb[i].slbv;
+ /*
+ * Only restore valid entries
+ */
+ if (rb & SLB_ESID_V) {
+ ppc_store_slb(env, rb, rs);
+ }
}
#endif
--
1.8.1.2
- [Qemu-devel] [PATCH -V4 RESEND 0/6] target-ppc: Add support for dumping guest memory using qemu gdb server, Aneesh Kumar K.V, 2013/10/01
- [Qemu-devel] [PATCH -V4 RESEND 4/6] target-ppc: Use #define for max slb entries, Aneesh Kumar K.V, 2013/10/01
- [Qemu-devel] [PATCH -V4 RESEND 1/6] target-ppc: Update slb array with correct index values.,
Aneesh Kumar K.V <=
- [Qemu-devel] [PATCH -V4 RESEND 6/6] target-ppc: dump-guest-memory support, Aneesh Kumar K.V, 2013/10/01
- [Qemu-devel] [PATCH -V4 RESEND 3/6] target-ppc: Check for error on address translation in memsave command, Aneesh Kumar K.V, 2013/10/01
- [Qemu-devel] [PATCH -V4 RESEND 5/6] dump-guest-memory: Check for the correct return value, Aneesh Kumar K.V, 2013/10/01
- [Qemu-devel] [PATCH -V4 RESEND 2/6] target-ppc: Fix page table lookup with kvm enabled, Aneesh Kumar K.V, 2013/10/01
- Re: [Qemu-devel] [PATCH -V4 RESEND 0/6] target-ppc: Add support for dumping guest memory using qemu gdb server, Alexander Graf, 2013/10/02